Add single missing variable to OMP private #6037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
mark-petersen
approved these changes
Oct 31, 2023
|
In MPAS standalone tests with gnu debug on chrysalis, master currently fails and this PR fixes it so they both pass. Thanks @jonbob! For some master passes with gnu optimized, so the tests do not always catch this problem. |
jonbob
added a commit
that referenced
this pull request
Nov 13, 2023
Add single missing variable to OMP private Adds one new variable to an OMP private directive in a recently modified routine. It doesn't appear to cause PET failures but still should be added. [non-BFB] potentially for threaded runs with active ocean
|
passes:
merged to next |
|
merged to master |
xylar
added a commit
to xylar/compass
that referenced
this pull request
Dec 3, 2023
This merge updates the E3SM-Project submodule from [894b5b2](https://github.com/E3SM-Project/E3SM/tree/894b5b2) to [5d5f15c](https://github.com/E3SM-Project/E3SM/tree/5d5f15c). This update includes the following MPAS-Ocean and MPAS-Frameworks PRs (check mark indicates bit-for-bit with previous PR in the list): - [ ] (ocn) E3SM-Project/E3SM#5945 - [ ] (ocn) E3SM-Project/E3SM#5946 - [ ] (ocn) E3SM-Project/E3SM#5947 - [ ] (ocn) E3SM-Project/E3SM#5999 - [ ] (ocn) E3SM-Project/E3SM#6037 - [ ] (ocn) E3SM-Project/E3SM#5989 - [ ] (ocn) E3SM-Project/E3SM#6035 - [ ] (ocn) E3SM-Project/E3SM#6077
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds one new variable to an OMP private directive in a recently modified routine. It doesn't appear to cause PET failures but still should be added.
[non-BFB] potentially for threaded runs with active ocean