Add OpenACC directives in the semi-implicit barotropic mode solver #5583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyungyukang
added
mpas-ocean
BFB
hyungyukang
changed the title
sarats
reviewed
Apr 6, 2023
sarats
reviewed
Apr 6, 2023
|
@hyungyukang, I will leave code review to whom knows this code well. My comment is about the list of git commits. It looks that there are many small git commits which will be shown in E3SM commit history. It may be good if you combine them as one or two commits before merging master branch. |
@grnydawn , Agreed. There would be more commits, so I will combine all of my commits before merging into master. Thanks for your suggestions! |
philipwjones
approved these changes
Apr 11, 2023
sarats
approved these changes
Apr 11, 2023
jonbob
added a commit
that referenced
this pull request
Apr 11, 2023
Add OpenACC directives in the semi-implicit barotropic mode solver The semi-implicit barotropic solver in E3SM ocean component has been ported on GPU by adding OpenACC directives. To compile MPAS-O with MAGMA or CUBLAS for GPU-accelerated linear algebra, some additions (USE_MAGMA, USE_CUBLAS) have been made to mpas-framework/Makefile. A subroutine si_halo_exch is added in the semi-implicit solver code, which is very experimental, to use GPU-aware MPI for local halo exchanges during solver iterations. The semi-implicit barotropic mode solver is not currently used in E3SM, so it does not affect default configurations. [BFB]
|
passes:
merged to next |
- Porting the semi-implicit barotropic mode solver on GPU using OpenACC directives - Update Makefile for MAGMA, CUBLAS, GPU_AWARE_MPI use - A subroutine 'si_halo_exch' is added in the SI solver code, which is very experimental, to use GPU-aware MPI for local halo exchanges during solver iterations. Add SI halo exch routine and related codes Implmentation of si_halo_exch Add SI solver opencacc code
hyungyukang
force-pushed
the
hkang/ocean/si-openacc
branch
from
5681515 to
a6b2f55
Compare
|
@sarats , @philipwjones, @grnydawn , and @jonbob , Thanks a lot for reviewing and testing and your approval! |
|
merged to master |
xylar
added a commit
to xylar/compass
that referenced
this pull request
Apr 18, 2023
This merge updates the E3SM-Project submodule from [c292bec000](https://github.com/E3SM-Project/E3SM/tree/c292bec000) to [4b3e611fee](https://github.com/E3SM-Project/E3SM/tree/4b3e611fee). This update includes the following MPAS-Ocean and MPAS-Frameworks PRs (check mark indicates bit-for-bit with previous PR in the list): - [ ] (ocn) E3SM-Project/E3SM#5418 - [ ] (ocn) E3SM-Project/E3SM#5447 - [ ] (ocn) E3SM-Project/E3SM#5568 - [ ] (ocn) E3SM-Project/E3SM#5583 - [ ] (ocn) E3SM-Project/E3SM#5575 - [ ] (ocn) E3SM-Project/E3SM#5600
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The semi-implicit barotropic solver in E3SM ocean component has been ported on GPU by adding OpenACC directives.
Running and testing have been done for the stand-alone MPAS-O on Summit only at this moment, and how to run and test on Summit is documented in E3SM Confluence: https://acme-climate.atlassian.net/wiki/spaces/OO/pages/3718087262/Running+MPAS-Ocean+with+a+GPU-accelerated+semi-implicit+barotropic+mode+solver+option
To compile MPAS-O with MAGMA or CUBLAS for GPU-accelerated linear algebras, some additions (
USE_MAGMA,USE_CUBLAS) have been made tompas-framework/MakefileA subroutine
si_halo_exchis added in the semi-implicit solver code, which is very experimental, to use GPU-aware MPI for local halo exchanges during solver iterations. It currently works on GPU but much slower than the data staging halo exchange. The subroutine will be further optimized.The semi-implicit barotropic mode solver is a stealth function, so it does not affect to default configurations.