Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase initial soil moisture in fates runs #5508

Merged

Conversation

JessicaNeedham
Copy link

@JessicaNeedham JessicaNeedham commented Mar 6, 2023

This PR changes the condition for a higher initial value of soil moisture so that all FATES runs, not just FATES-Hydro, will be initialized with higher soil moisture. This is to improve the establishment of forest in bare ground simulations.
See FATES issue here NGEET/fates#994 and discussion here NGEET/fates#985.

This change should be B4B in non-FATES runs and non-B4B in FATES runs.

@JessicaNeedham
Copy link
Author

For discussion on the corresponding CTSM PR see here: ESCOMP/CTSM#1962

@rljacob rljacob requested a review from rgknox March 7, 2023 18:00
@glemieux
Copy link
Contributor

glemieux commented Mar 7, 2023

Regression testing underway on perlmutter.

@glemieux
Copy link
Contributor

glemieux commented Mar 7, 2023

All non-fates tests are B4B with the fates tests passing RUN, but not B4B as expected. Three tests (non-fates) returned computation time increases.

Folder location: /pscratch/sd/g/glemieux/e3sm-tests/pr5508.fates.pm-cpu.gnu.Cc6f43d321b-F77753581

Copy link
Contributor

@rgknox rgknox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! thanks @JessicaNeedham

peterdschwartz added a commit that referenced this pull request Apr 3, 2023
… (PR #5508)

This PR changes the condition for a higher initial value of soil moisture so that all FATES runs,
not just FATES-Hydro, will be initialized with higher soil moisture.
This is to improve the establishment of forest in bare ground simulations.
See FATES issue here NGEET/fates#994 and discussion here NGEET/fates#985.

[non-BFB] for FATES only
@peterdschwartz
Copy link
Contributor

merged to next

@peterdschwartz peterdschwartz merged commit a3b334c into E3SM-Project:master Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants