Fix the call to SatellitePhenology when fates is active

[glemieux]

Move the fates-specific satellitephenology call out of an area that is unreachable when fates is active.

Fixes NGEET/fates#953.

[Non-B4B]

[glemieux]

Perlmutter E3SM land developer tests against master baseline are complete (I merged master into this branch locally, but did not push). All but 2 tests are b4b. One DIFF in the fates satphen test as expected. The test with the hcru_hcru resolution failed to run however. The testlog had an error I wasn't familiar with:

 ---------------------------------------------------
2022-12-01 15:20:17: OLD FAIL: Potentially broken merges:
3b28b97f2f3ab181b1cdabf8d618256f2360f8e6
c0381621ba5653261e70edc1463bd17b7bc87d4a
 ---------------------------------------------------

Folder location on perlmutter: /global/homes/g/glemieux/pm-scratch/e3sm-tests/pr5345.fates.pm-cpu.gnu.Cb4cb329d34-Fdef6b3e7

[bishtgautam]

@glemieux, I could not access the /global/homes/g/glemieux/pm-scratch/e3sm-tests/pr5345.fates.pm-cpu.gnu.Cb4cb329d34-Fdef6b3e7. Btw, instead of merging master locally, you can rebase your branch off the latest master before testing.

[glemieux]

Sorry about that @bishtgautam; I've opened up all the folders in my scratch directory to be readable by all now. Thanks.

[glemieux]

Upon a resubmit the hrcu_hrcu test that failed to RUN is passing now.

[rgknox]

good stuff, thanks @glemieux

[bishtgautam]

This PR is now merged to next. A minor comment regarding renaming your future branches: E3SM is following the following naming convention: <username/component-name/short-useful-name>. So, this branch could be named <glemieux/lnd/fates-satphen-mode>.

[glemieux]

This PR is now merged to next. A minor comment regarding renaming your future branches: E3SM is following the following naming convention: <username/component-name/short-useful-name>. So, this branch could be named <glemieux/lnd/fates-satphen-mode>.

Thanks for the reminder @bishtgautam