Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing variables to omp pragmas from PR #5195 #5226

Merged
merged 1 commit into from
Oct 11, 2022
Merged

Add missing variables to omp pragmas from PR #5195 #5226

merged 1 commit into from
Oct 11, 2022

Conversation

jonbob
Copy link
Contributor

@jonbob jonbob commented Oct 7, 2022

PR #5195 added new code, but had some variables missing from omp pragmas that cause SMS_D_Ld3.T62_oQU120.CMPASO-IAF.chrysalis_intel failures. This fixes that issue.

[non-BFB] for threaded tests

@jonbob jonbob added mpas-ocean non-BFB PR makes roundoff changes to answers. labels Oct 7, 2022
@jonbob jonbob requested a review from mark-petersen October 7, 2022 16:00
@jonbob jonbob self-assigned this Oct 7, 2022
@jonbob
Copy link
Contributor Author

jonbob commented Oct 7, 2022

SMS_D_Ld3.T62_oQU120.CMPASO-IAF.chrysalis_intel tests using master were not repeatable. After this change, I was able to run five cases with that configuration, all of which had BFB results

@jonbob jonbob mentioned this pull request Oct 7, 2022
Merged
@jonbob
Copy link
Contributor Author

jonbob commented Oct 10, 2022

@mark-petersen -- can you please review this?

mark-petersen
mark-petersen approved these changes Oct 10, 2022
View reviewed changes
Copy link
Contributor

@mark-petersen mark-petersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by visual inspection, checking for thread-independent variables within loop.

jonbob added a commit that referenced this pull request Oct 10, 2022
@jonbob
Merge branch 'jonbob/ocean/fix-thickness-threading' into next (PR #5226)
0cfeb76 
Add missing variables to omp pragmas from PR #5195

PR #5195 added new code, but had some variables missing from omp pragmas
that cause SMS_D_Ld3.T62_oQU120.CMPASO-IAF.chrysalis_intel failures.
This fixes that issue.

[non-BFB] for threaded tests
@jonbob
Copy link
Contributor Author

jonbob commented Oct 11, 2022

test merge passes:

  • ERS_Ld5.T62_oQU120.CMPASO-NYF.chrysalis_intel
  • ERS_D_Ld5.T62_oQU120.CMPASO-NYF.chrysalis_intel
  • SMS_D_Ld1.ne30pg2_EC30to60E2r2.WCYCL1850.chrysalis_intel.allactive-wcprod

merged to next

@jonbob jonbob merged commit 47f4c4e into master Oct 11, 2022
@jonbob jonbob deleted the jonbob/ocean/fix-thickness-threading branch October 11, 2022 17:08
@jonbob
Copy link
Contributor Author

jonbob commented Oct 11, 2022

merged to master and expected DIFF blessed

@xylar xylar mentioned this pull request Nov 19, 2022
Merged
32 tasks
@xylar xylar mentioned this pull request Nov 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mark-petersen mark-petersen mark-petersen approved these changes

Assignees

@jonbob jonbob

Labels
mpas-ocean non-BFB PR makes roundoff changes to answers.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonbob @mark-petersen