Add mpas-framework support for several other attributes #5183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xylar
approved these changes
Sep 10, 2022
There was a problem hiding this comment.
Approved based on my testing in E3SM-Ocean-Discussion#28 and the ocean pr test suite, which I found to be BFB with the base of this branch (fa1d32e).
@jonbob, let me know if you would like me to do any additional testing (e.g. in E3SM).
|
@cbegeman, I believe this is ready for you to have a look at when you have some time. |
jonbob
added a commit
that referenced
this pull request
Sep 20, 2022
Add mpas-framework support for several other attributes Adds parsing support to the mpas-framework for the following attributes: * bounds * cell_measures * cell_method * coordinates * standard_name See additional discussion in E3SM-Ocean-Discussion PR #28 [BFB]
|
merged to master |
32 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds parsing support to the mpas-framework for the following attributes:
See discussion in E3SM-Ocean-Discussion PR #28
[BFB]