Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 5 ice-shelf BL fields to MPAS-Ocean monthly output #5010

Merged

Conversation

xylar
Copy link
Contributor

@xylar xylar commented Jun 5, 2022

Collaborators have requested that these fields always be included in simulations with ice-shelf cavities so they can study the relationship between melt rates, thermal driving and friction velocity in the sub-ice-shelf boundary layer across many models.

This output would also likely be of interest to us, particularly as we explore new vertical coordinates in ice-shelf cavities.

Collaborators have requested that these fields always be included
in simulations with ice-shelf cavities so they can study the
relationship between melt rates, thermal driving and friction
velocity in the sub-ice-shelf boundary layer across many models.

This output would also likely be of interest to us, particularly
as we explore new vertical coordinates in ice-shelf cavities.
@xylar
Copy link
Contributor Author

xylar commented Jun 5, 2022

Testing

I did two 1-year test QUwLI240 runs on Anvil, one without ice-shelf fluxes (pressure-only) and one with ice-shelf fluxes (standalone). timeSeriesStatsMonthly files sizes are nearly identical (121 MB without ice-shelf fluxes and 122 MB with). So all of the fields related to ice-shelf fluxes (including these 5 new ones) are in the noise.

Output of the test without ice-shelf fluxes is here:
/lcrc/group/e3sm/ac.xylar/scratch/anvil/20220603.GMPAS-IAF.T62_oQU240wLI.anvil/run
And with is here:
/lcrc/group/e3sm/ac.xylar/scratch/anvil/20220604.GMPAS-IAF.T62_oQU240wLI.anvil/run

@xylar xylar added the NML label Jun 5, 2022
@xylar
Copy link
Contributor Author

xylar commented Jun 5, 2022

@jonbob, am I right that streams changes also qualify for the NML tag?

@xylar xylar changed the title Add 5 ice-shelf BL fields to monthly output Add 5 ice-shelf BL fields to MPAS-Ocean monthly output Jun 5, 2022
@jonbob
Copy link
Contributor

jonbob commented Jun 6, 2022

@xylar -- the streams files don't get compared as part of the NML test, so we can remove that label

@jonbob jonbob removed the NML label Jun 6, 2022
@jonbob
Copy link
Contributor

jonbob commented Jun 6, 2022

@xylar - it is possible to make these extra fields only be added to the streams for wISC grids, if that would be preferable

@xylar
Copy link
Contributor Author

xylar commented Jun 7, 2022

@jonbob,

it is possible to make these extra fields only be added to the streams for wISC grids, if that would be preferable

I was aware that would be possible but I don't think it's necessary. Internally, MPAS-Ocean also disables (doesn't even allocate) these fields in runs without ice-shelf cavities. So they will only be included in runs not only with ice-shelf cavities but with ice-shelf melt fluxes. Since we haven't made any effort to treat existing fields with the landIce prefix in any special way for wISC runs, I think it's consistent to let MPAS-Ocean take care of it for these 5 fields as well.

Let me know if you prefer to exclude them nonetheless.

Copy link
Contributor

@cbegeman cbegeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xylar This addition will be useful to have! It looks good to me based on visual inspection. Let me know if you'd like help with any testing.

@jonbob
Copy link
Contributor

jonbob commented Jun 7, 2022

@xylar - I think your implementation is fine. Just thought I'd point out the possibility, just in case it made the non-wISC output any clearer. But as you said, the impact is in the noise

Copy link
Member

@darincomeau darincomeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve by visual inspection.

@xylar xylar removed the request for review from mark-petersen June 14, 2022 14:45
@xylar
Copy link
Contributor Author

xylar commented Jun 14, 2022

@mark-petersen, I'm taking you off as a reviewer. We had plenty of eyes on this.

@xylar
Copy link
Contributor Author

xylar commented Jun 14, 2022

Thanks, @milenaveneziani, @darincomeau and @jonbob for your feedback!

@xylar
Copy link
Contributor Author

xylar commented Jun 14, 2022

... and @cbegeman (so sorry I missed you!)

jonbob added a commit that referenced this pull request Jun 14, 2022
…t (PR #5010)

Add 5 ice-shelf BL fields to MPAS-Ocean monthly output

Collaborators have requested that these fields always be included in
simulations with ice-shelf cavities so they can study the relationship
between melt rates, thermal driving and friction velocity in the
sub-ice-shelf boundary layer across many models.

This output would also likely be of interest to us, particularly as we
explore new vertical coordinates in ice-shelf cavities.

[BFB]
@jonbob
Copy link
Contributor

jonbob commented Jun 14, 2022

Passes sanity testing, merged to next

@jonbob jonbob merged commit ea2c1b4 into E3SM-Project:master Jun 15, 2022
@jonbob
Copy link
Contributor

jonbob commented Jun 15, 2022

merged to master

@xylar xylar deleted the ocn/add-ice-shelf-boundary-layer-output branch June 15, 2022 18:03
@xylar
Copy link
Contributor Author

xylar commented Jun 15, 2022

@jonbob, thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BFB PR leaves answers BFB mpas-ocean
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants