-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 5 ice-shelf BL fields to MPAS-Ocean monthly output #5010
Add 5 ice-shelf BL fields to MPAS-Ocean monthly output #5010
Conversation
Collaborators have requested that these fields always be included in simulations with ice-shelf cavities so they can study the relationship between melt rates, thermal driving and friction velocity in the sub-ice-shelf boundary layer across many models. This output would also likely be of interest to us, particularly as we explore new vertical coordinates in ice-shelf cavities.
TestingI did two 1-year test QUwLI240 runs on Anvil, one without ice-shelf fluxes ( Output of the test without ice-shelf fluxes is here: |
@jonbob, am I right that streams changes also qualify for the |
@xylar -- the streams files don't get compared as part of the NML test, so we can remove that label |
@xylar - it is possible to make these extra fields only be added to the streams for wISC grids, if that would be preferable |
I was aware that would be possible but I don't think it's necessary. Internally, MPAS-Ocean also disables (doesn't even allocate) these fields in runs without ice-shelf cavities. So they will only be included in runs not only with ice-shelf cavities but with ice-shelf melt fluxes. Since we haven't made any effort to treat existing fields with the Let me know if you prefer to exclude them nonetheless. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xylar This addition will be useful to have! It looks good to me based on visual inspection. Let me know if you'd like help with any testing.
@xylar - I think your implementation is fine. Just thought I'd point out the possibility, just in case it made the non-wISC output any clearer. But as you said, the impact is in the noise |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve by visual inspection.
@mark-petersen, I'm taking you off as a reviewer. We had plenty of eyes on this. |
Thanks, @milenaveneziani, @darincomeau and @jonbob for your feedback! |
... and @cbegeman (so sorry I missed you!) |
…t (PR #5010) Add 5 ice-shelf BL fields to MPAS-Ocean monthly output Collaborators have requested that these fields always be included in simulations with ice-shelf cavities so they can study the relationship between melt rates, thermal driving and friction velocity in the sub-ice-shelf boundary layer across many models. This output would also likely be of interest to us, particularly as we explore new vertical coordinates in ice-shelf cavities. [BFB]
Passes sanity testing, merged to next |
merged to master |
@jonbob, thanks a lot! |
Collaborators have requested that these fields always be included in simulations with ice-shelf cavities so they can study the relationship between melt rates, thermal driving and friction velocity in the sub-ice-shelf boundary layer across many models.
This output would also likely be of interest to us, particularly as we explore new vertical coordinates in ice-shelf cavities.