Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow up to 15 EAM history tapes #4892

Merged
merged 2 commits into from
Jun 16, 2022
Merged

Conversation

tangq
Copy link
Contributor

@tangq tangq commented Apr 15, 2022

The "SPECIAL" v2 production runs require more than 10 EAM history output tapes (https://acme-climate.atlassian.net/wiki/spaces/EWCG/pages/1850376218/E3SMv2+history+variable+namelists+for+production+runs), exceeding the current limit (10 tapes). This PR includes changes to both the code and namelist variables and increases the limit to 15 tapes.

We should merge this to both maint-2.0 and master, but when I issued the PR for merging to maint-2.0 (#4891), lots of unrelated commits were included (We only need the two commits in the present PR). I am not sure how to fix the PR to maint-2.0, so closed it for now.

The tests are successful and located at /lcrc/group/e3sm/ac.qtang/E3SMv2/test-output-maint-2.0.v2.NARRM.amip/tests.

tangq added 2 commits April 14, 2022 19:38
Modify the namelist variables to allow up to 15 EAM output tapes.

[BFB] - Bit-For-Bit
[NML] - Namelist Changing
@rljacob
Copy link
Member

rljacob commented May 26, 2022

@beharrop please review.

Copy link
Contributor

@beharrop beharrop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of the changes look good to me. Thanks @tangq . @singhbalwinder this has my approval for moving forward.

wlin7 added a commit that referenced this pull request May 28, 2022
This is to mirror PR #4892 for master to increase eam history tapes
up to 15 to accomodate more extensive output configurations.

[BFB]
singhbalwinder added a commit that referenced this pull request May 31, 2022
Allow up to 15 EAM history tapes

The "SPECIAL" v2 production runs require more than 10 EAM history
output tapes (https://acme-climate.atlassian.net/wiki/spaces/EWCG/
pages/1850376218/E3SMv2+history+variable+namelists+for+production+
runs), exceeding the current limit (10 tapes). This PR includes
changes to both the code and namelist variables and increases the
limit to 15 tapes.

We should merge this to both maint-2.0 and master, but when I issued
the PR for merging to maint-2.0 (#4891), lots of unrelated commits
were included (We only need the two commits in the present PR). I am
not sure how to fix the PR to maint-2.0, so closed it for now.

The tests are successful and located at /lcrc/group/e3sm/ac.qtang/
E3SMv2/test-output-maint-2.0.v2.NARRM.amip/tests.

* tangq/atm/increase_eam_tapes:
  Change code to support up to 15 EAM tapes
  Increase the max number of EAM history tapes to 15
@singhbalwinder
Copy link
Contributor

Merged to next

wlin7 added a commit that referenced this pull request Jun 15, 2022
Added support to allow eam history tapes up to 15

This is to mirror PR #4892 for master to increase eam history tapes
up to 15 to accomodate more extensive output configurations.

[BFB]
@rljacob
Copy link
Member

rljacob commented Jun 16, 2022

@singhbalwinder please merge to master.

@singhbalwinder singhbalwinder merged commit 0d791e6 into master Jun 16, 2022
@tangq tangq deleted the tangq/atm/increase_eam_tapes branch November 11, 2022 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Atmosphere BFB PR leaves answers BFB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants