-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow up to 15 EAM history tapes #4892
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify the namelist variables to allow up to 15 EAM output tapes. [BFB] - Bit-For-Bit [NML] - Namelist Changing
@beharrop please review. |
beharrop
approved these changes
May 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of the changes look good to me. Thanks @tangq . @singhbalwinder this has my approval for moving forward.
wlin7
added a commit
that referenced
this pull request
May 28, 2022
This is to mirror PR #4892 for master to increase eam history tapes up to 15 to accomodate more extensive output configurations. [BFB]
singhbalwinder
added a commit
that referenced
this pull request
May 31, 2022
Allow up to 15 EAM history tapes The "SPECIAL" v2 production runs require more than 10 EAM history output tapes (https://acme-climate.atlassian.net/wiki/spaces/EWCG/ pages/1850376218/E3SMv2+history+variable+namelists+for+production+ runs), exceeding the current limit (10 tapes). This PR includes changes to both the code and namelist variables and increases the limit to 15 tapes. We should merge this to both maint-2.0 and master, but when I issued the PR for merging to maint-2.0 (#4891), lots of unrelated commits were included (We only need the two commits in the present PR). I am not sure how to fix the PR to maint-2.0, so closed it for now. The tests are successful and located at /lcrc/group/e3sm/ac.qtang/ E3SMv2/test-output-maint-2.0.v2.NARRM.amip/tests. * tangq/atm/increase_eam_tapes: Change code to support up to 15 EAM tapes Increase the max number of EAM history tapes to 15
Merged to next |
wlin7
added a commit
that referenced
this pull request
Jun 15, 2022
Added support to allow eam history tapes up to 15 This is to mirror PR #4892 for master to increase eam history tapes up to 15 to accomodate more extensive output configurations. [BFB]
@singhbalwinder please merge to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "SPECIAL" v2 production runs require more than 10 EAM history output tapes (https://acme-climate.atlassian.net/wiki/spaces/EWCG/pages/1850376218/E3SMv2+history+variable+namelists+for+production+runs), exceeding the current limit (10 tapes). This PR includes changes to both the code and namelist variables and increases the limit to 15 tapes.
We should merge this to both maint-2.0 and master, but when I issued the PR for merging to maint-2.0 (#4891), lots of unrelated commits were included (We only need the two commits in the present PR). I am not sure how to fix the PR to maint-2.0, so closed it for now.
The tests are successful and located at /lcrc/group/e3sm/ac.qtang/E3SMv2/test-output-maint-2.0.v2.NARRM.amip/tests.