Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hard to add new options for sea ice velocity solver #5289

Closed
akturner opened this issue Nov 10, 2022 · 0 comments · Fixed by #5290
Closed

Hard to add new options for sea ice velocity solver #5289

akturner opened this issue Nov 10, 2022 · 0 comments · Fixed by #5290
Labels
mpas-seaice

Comments

@akturner
Copy link
Contributor

The MPAS-Seaice velocity solver is poorly organized with various fields retrieved from the domain object on inconsistent subroutine levels. This makes the code hard to read and difficult to add new options. The domain object should be passed as the only function argument to the computation levels.
@akturner akturner mentioned this issue Nov 10, 2022
Merged
jonbob added a commit that referenced this issue Dec 14, 2022
@jonbob
Merge branch 'akturner/mpas-seaice/refactor-velocity-init' into next …
c8e285d 
…(PR #5290)

Refactor of MPAS-Seaice velocity solver

Refactor of MPAS sea ice velocity solver to allow easier testing of new
options and methods, including:
* Move domain reference to within subroutines avoiding messy passing of
  variables
* Move wachspress basis routines to separate module
* Move triangular quadrature rules to new module
* Move some mesh related routines to the mesh module
* Rename block variable to blockPtr
* Rename all pool types to end in Pool

Fixes #5289

[BFB]
@jonbob jonbob closed this as completed in 4b872d5 Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
mpas-seaice
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor of MPAS-Seaice velocity solver akturner/E3SM
1 participant
@akturner