Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix threading issue in submesoscale code #5215

Closed
jonbob opened this issue Oct 4, 2022 · 0 comments · Fixed by #5216
Closed

Fix threading issue in submesoscale code #5215

jonbob opened this issue Oct 4, 2022 · 0 comments · Fixed by #5216
Labels
bug mpas-ocean

Comments

@jonbob
Copy link
Contributor

jonbob commented Oct 4, 2022

Merging PR #5172, which turned on the submesoscale model by default, caused SMS_D_Ld3.T62_oQU120.CMPASO-IAF.chrysalis_intel to start failing. Testing shows it fails only in debug mode and only with threading on
@jonbob jonbob mentioned this issue Oct 4, 2022
Merged
jonbob added a commit that referenced this issue Oct 5, 2022
@jonbob
Merge branch 'jonbob/ocean/fix-submeso-threading' into next (PR #5216)
4993a9d 
Fix threading issues in submesoscale code

Adds some missing variables to the omp pragmas in the new submesoscale
model code, to fix some issues with a test not being reproducible with
threading and debug on.

Fixes #5215

[non-BFB] only with threading on
@jonbob jonbob closed this as completed in 188ad0d Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug mpas-ocean
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix threading issues in submesoscale code E3SM-Project/E3SM
1 participant
@jonbob