Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MPAS input overwrites registry attributes #4986

Closed
akturner opened this issue May 26, 2022 · 0 comments · Fixed by #4987
Closed

MPAS input overwrites registry attributes #4986

akturner opened this issue May 26, 2022 · 0 comments · Fixed by #4987
Labels
mpas-framework

Comments

@akturner
Copy link
Contributor

When reading in a file to MPAS, attributes in the input file overwrite attributes for a field that are set in the Registry. This potentially overwrites CF-compliant units in the Registry with non-CF compliant units in the input file.
@akturner akturner mentioned this issue May 26, 2022
Merged
jonbob added a commit that referenced this issue Jun 27, 2022
@jonbob
Merge branch 'akturner/cf_units_io_overwrite_bug' into next (PR #4987)
e7619aa 
Remove functionality from MPAS framework that overwrites attributes

Removes functionality from MPAS framework that overwrites Registry
attributes with stream file attributes. This change prevents input files
from overwriting CF-compliant units in Registry with non-CF compliant
ones in the input file.

Fixes #4986

[BFB]
@jonbob jonbob closed this as completed in 87dad35 Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
mpas-framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removed functionality from MPAS framework that overwrites attributes akturner/E3SM
1 participant
@akturner