Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FATES SatPhen test failing with GNU compiler #4755

Closed
peterdschwartz opened this issue Jan 26, 2022 · 4 comments
Closed

FATES SatPhen test failing with GNU compiler #4755

peterdschwartz opened this issue Jan 26, 2022 · 4 comments
Assignees
@glemieux
Labels
FATES GNU GNU compiler related issues Land

Comments

@peterdschwartz
Copy link
Contributor

The new SMS_Ld30.f45_f45.IELMFATES.mappy_gnu.elm-fates_satphen (from PR #4669 ) test is failing. I replicated it on chrysalis using the gnu compiler. The FAIL goes away if optimizations are disabled.

@glemieux @rgknox
@peterdschwartz peterdschwartz added Land FATES GNU GNU compiler related issues labels Jan 26, 2022
@glemieux
Copy link
Contributor

I've got a couple tests queued up on Cori to try and replicate it. Hopefully I'll have some insight into this soon.

@glemieux
Copy link
Contributor

@peterdschwartz I can confirm I'm seeing a similar failure on Cori using the gnu compiler. @rgknox I think I've figured out the issue. I'll post a new issue on the fates repo once I have it nailed down. It looks like it'll be all on the fates side, so maybe we can get it in with the next elm-fates API update.

@peterdschwartz
Copy link
Contributor Author

@glemieux Can you verify that the cases on cori pass if you run them in debug mode? We may be able to modify the test on mappy to use debug mode while waiting for the fates update so that the testing dashboard is clean.

@glemieux
Copy link
Contributor

@peterdschwartz yes I'm seeing the same thing: if I run with the gnu compiler in debug the test will pass.

@glemieux glemieux mentioned this issue Jan 28, 2022
Closed
@peterdschwartz peterdschwartz mentioned this issue Feb 15, 2022
Merged
@glemieux glemieux mentioned this issue Feb 28, 2022
Closed
peterdschwartz pushed a commit that referenced this issue Mar 17, 2022
Merge remote-tracking branch 'rgknoxfork/rgknox/lnd/fates-api21' into…
0392afb 
… next (PR #4777)

This set of changes brings E3SM into compatability with FATES API 21, and updates the pointer to tag: sci.1.53.0_api.21.0.0.
Recent API changes accomodate an overhaul to FATES history variables (including new testdef definitions on E3SM side),
passing of canopy snow fraction to FATES, and accomodation of history reporting of variable LAI bin widths in FATES.

Fixes Issue #4755 and Fixes Issue #4816

[non-BFB] for FATES tests
peterdschwartz pushed a commit that referenced this issue Mar 18, 2022
Merge remote-tracking branch 'rgknoxfork/rgknox/lnd/fates-api21' (PR #…
9664de8 
…4777)

This set of changes brings E3SM into compatability with FATES API 21, and updates the pointer to tag: sci.1.53.0_api.21.0.0.
Recent API changes accomodate an overhaul to FATES history variables (including new testdef definitions on E3SM side),
passing of canopy snow fraction to FATES, and accomodation of history reporting of variable LAI bin widths in FATES.

Fixes Issue #4755 and Fixes Issue #4816

[non-BFB] for FATES tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@glemieux glemieux

Labels
FATES GNU GNU compiler related issues Land
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@glemieux @peterdschwartz