Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLM providing invalid starts/counts to the PIO #2778

Closed
bishtgautam opened this issue Mar 6, 2019 · 3 comments · Fixed by #2772
Closed

CLM providing invalid starts/counts to the PIO #2778

bishtgautam opened this issue Mar 6, 2019 · 3 comments · Fixed by #2772
Assignees
@jayeshkrishna
Labels
bug Land PIO

Comments

@bishtgautam
Copy link
Contributor

CLM is providing invalid starts/counts to the PIO library and this commit fixes that issue.
With PIO1 the entire library is implemented in fortran and since fortran arrays always include the size with it these bugs did not show up (inadvertently). When testing with PIO2 these bugs showed up.
@bishtgautam bishtgautam added the bug label Mar 6, 2019
@jayeshkrishna jayeshkrishna mentioned this issue Mar 6, 2019
Merged
@bishtgautam
Copy link
Contributor Author

@jayeshkrishna, I was wondering if we should also inform NCAR about this issue, if you haven't already done so. What do you think?

@jayeshkrishna
Copy link
Contributor

jayeshkrishna commented Mar 6, 2019 via email •
edited
Loading

@jayeshkrishna
Copy link
Contributor

In any case it might be useful to ping them and see if they have seen the issue.

jayeshkrishna added a commit that referenced this issue Mar 15, 2019
@jayeshkrishna
Merge branch 'jayeshkrishna/pio2_clm_mosart_fixes' into next (PR #2772)
ad9edaa 
This PR includes some fixes in CLM and Mosart required for PIO2.

Although these fixes are not specific to PIO2, they showed up
during testing with PIO2.

Fixes #2778
[BFB]

* jayeshkrishna/pio2_clm_mosart_fixes:
  Fixing starts/counts for pio puts
  Commenting out LND_PIO_REARRANGER entry in config_pio.xml for E3SM
jayeshkrishna added a commit that referenced this issue Mar 18, 2019
@jayeshkrishna
Merge pull request #2772 from E3SM-Project/jayeshkrishna/pio2_clm_mos…
4c4aeff 
…art_fixes

This PR includes some fixes in CLM and Mosart required for PIO2.

Although these fixes are not specific to PIO2, they showed up during testing with PIO2.

Fixes #2778
[BFB]
jgfouca pushed a commit that referenced this issue Jun 25, 2019
@jayeshkrishna
Merge pull request #2772 from E3SM-Project/jayeshkrishna/pio2_clm_mos…
802bbc4 
…art_fixes

This PR includes some fixes in CLM and Mosart required for PIO2.

Although these fixes are not specific to PIO2, they showed up during testing with PIO2.

Fixes #2778
[BFB]
@dqwu dqwu mentioned this issue Sep 9, 2019
Closed
jayeshkrishna added a commit that referenced this issue Oct 4, 2019
@jayeshkrishna
Merge branch 'jayeshkrishna/pio2_clm_mosart_fixes_for_maint' into jay…
f79c19d 
…eshkrishna/scorpio_on_maint_1_0

This merge includes some fixes in CLM and Mosart required for PIO2.

Although these fixes are not specific to PIO2, they showed up during
testing with PIO2.

See #2778
[BFB]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jayeshkrishna jayeshkrishna

Labels
bug Land PIO
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CLM & Mosart fixes for PIO2 E3SM-Project/E3SM
2 participants
@jayeshkrishna @bishtgautam