Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specification 2.1.0 #37

Merged
merged 6 commits into from
May 31, 2024
Merged

Specification 2.1.0 #37

merged 6 commits into from
May 31, 2024

Conversation

dockmd
Copy link
Collaborator

@dockmd dockmd commented May 22, 2024

  • Implemented specification 2.1.0
  • Changed structure, so the version of the specification can be taken into account
  • Version of specification can be passed as program parameter - 'V2.0.4' or 'V2.1.0' for now

@dockmd dockmd requested a review from carlwilson May 22, 2024 15:51
@dockmd dockmd changed the base branch from main to integration May 22, 2024 15:52
Copy link
Member

@carlwilson carlwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll not pretend that I've reviewed the rules properly but they are probably best QA'd away from this. I'd like the chance to build and test here before committing on the review but it looks good generally.

Copy link
Member

@carlwilson carlwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do take a look at the pylint issue that's stopping the GH actions build please @dockmd but nice work.

@dockmd dockmd merged commit 21c6437 into integration May 31, 2024
4 checks passed
@dockmd dockmd deleted the feat/V2.1.0-specification branch May 31, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants