Feature/741/demo k3s #750
Merged
Feature/741/demo k3s #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eemrdog
approved these changes
Nov 26, 2024
| --- | ||
| apiVersion: networking.k8s.io/v1 | ||
| kind: Ingress | ||
| metadata: | ||
| annotations: | ||
| kubernetes.io/ingress.class: "{{ .Values.ingress.class }}" | ||
| nginx.ingress.kubernetes.io/canary: "{{ if .Values.ingress.isCanary }}true{{ else }}false{{ end }}" | ||
| nginx.ingress.kubernetes.io/canary-weight: "{{ .Values.ingress.canaryWeight }}" |
There was a problem hiding this comment.
is "canaryWeight" redundant here? As I see, if the ingress.mode is "canary" this weight parameter is not used. weight is only 1 or 0
| weighted: | ||
| services: | ||
| - name: {{ .Chart.Name }}-0 | ||
| weight: 1 |
There was a problem hiding this comment.
can canaryWeight value be used here?
There was a problem hiding this comment.
For the nginx ingress controller that is possible, but not for traefik, as it requires a weighting for each target service. I wanted to keep backwards compatibility for those who are using microk8s in combination with nginx ingress.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #741
Closes #739
Closes #643
Tested with the following use cases: