i#2154 Android64: Link static c++ runtime library #7239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Android splits the C++ STL runtime into a separate library which is not
provided as a standard system library. Applications are expected to
statically link the STL library (libc++_static.a) or distribute the
dynamic library with the application.
The NDK C++ support guide recommends using the shared library C++
runtime if you are building a shared library or an application that uses
shared libraries [1] so I have set the DynamoRIO CMake scripts to do
that by default and added code to deal with deploying libc++_shared.so.
This is handled in two places:
- drsyms CMakeLists.txt explicitly installs libc++_shared.so into
${INSTALL_EXT_LIB} with the other dependency libraries. This will
ensure the library is included when generating a DynamoRIO package.
- DynamoRIO_copy_target_to_device() now checks if a target it is
copying is a C++ target and automatically copies the runtime library
as well if it is.
[1] https://developer.android.com/ndk/guides/cpp-support#important_considerations
Issue: #2154, #1874
Change-Id: I4b2204daab68b6514a0d609adc1c5eb6b497065e
jackgallagher-arm
changed the title
derekbruening
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android splits the C++ STL runtime into a separate library which is not provided as a standard system library. Applications are expected to statically link the STL library (libc++_static.a) or distribute the dynamic library (libc++_shared.so) with the application [1].
All C++ targets should now be linking the static runtime libraries.
[1] https://developer.android.com/ndk/guides/cpp-support#important_considerations
Issue: #2154, #1874