Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update review process docs for final commit message #7150

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

derekbruening
Copy link
Contributor

Updates some old material in the section "Responding to Review Comments and Submitting Code Updates" of our docs which talked about later commit messages as though they became part of the final merge commit message, which is no longer true since we now use the pull request description.

Updates some old material in the section "Responding to Review
Comments and Submitting Code Updates" of our docs which talked about
later commit messages as though they became part of the final merge
commit message, which is no longer true since we now use the pull
request description.
api/docs/code_reviews.dox Outdated Show resolved Hide resolved
api/docs/code_reviews.dox Outdated Show resolved Hide resolved
@derekbruening derekbruening merged commit c0ebcbb into master Dec 17, 2024
17 checks passed
@derekbruening derekbruening deleted the iX-update-review-docs branch December 17, 2024 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants