Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i#6662 regdeps: Invariant checks for filetype and cpuid #7100

Merged
merged 9 commits into from
Dec 5, 2024

Conversation

edeiana
Copy link
Contributor

@edeiana edeiana commented Nov 28, 2024

Public traces (i.e., OFFLINE_FILE_TYPE_ARCH_REGDEPS traces) have a new
constraint: TRACE_MARKER_TYPE_CPU_ID values must all be -1 as we don't
want to expose a CPU schedule. We add this constraint as invariant in the
invariant_checker.

We also add an invariant for the trace file type, which should not contain any
OFFLINE_FILE_TYPE_ARCH_* information except for
OFFLINE_FILE_TYPE_ARCH_REGDEPS.

Issue #6662

Public traces (i.e., OFFLINE_FILE_TYPE_ARCH_REGDEPS traces) have a new
constraint: TRACE_MARKER_TYPE_CPU_ID values must all be -1 as we don't
want to expose a CPU schedule.

We add this constraint as invariant in the invariant_checker.
We also add an invariant for the trace file type, which should not
contain any OFFLINE_FILE_TYPE_ARCH_* information except for
OFFLINE_FILE_TYPE_ARCH_REGDEPS.

Issue #6662
@edeiana
Copy link
Contributor Author

edeiana commented Nov 28, 2024

code_api|tool.drcachesim.coherence failed on ci-x86 / x86-64 (pull_request):

2024-11-28T03:48:11.0247145Z 319: 
2024-11-28T03:48:11.0247551Z 319:      Finished computing current solution distance in mode 0.
2024-11-28T03:48:11.0248094Z 319:      Mode changed to 0.
2024-11-28T03:48:11.0248447Z 319: 
2024-11-28T03:48:11.0248778Z 319:      Started iteration 2 of the computation...
2024-11-28T03:48:11.0249227Z 319: 
2024-11-28T03:48:11.0249626Z 319:      Finished computing current solution distance in mode 0.
2024-11-28T03:48:11.0250159Z 319:      Mode changed to 0.
2024-11-28T03:48:11.0250507Z 320: 
2024-11-28T03:48:11.0250836Z 320:      Started iteration 1 of the computation...
2024-11-28T03:48:11.0251401Z 319: 
2024-11-28T03:48:11.0251747Z 319:      Started iteration 3 of the computation...
2024-11-28T03:48:11.0252191Z 319: 
2024-11-28T03:48:11.0252588Z 319:      Finished computing current solution distance in mode 0.
2024-11-28T03:48:11.0253126Z 319:      Mode changed to 0.
2024-11-28T03:48:11.0253464Z 319: 
2024-11-28T03:48:11.0253712Z 319: 
2024-11-28T03:48:11.0254022Z 319:      The Jacobi Method For AX=B .........DONE
2024-11-28T03:48:11.0254507Z 319:      Total Number Of iterations   :  3
2024-11-28T03:48:11.0255015Z 319:     ...................................................................
2024-11-28T03:48:11.0255626Z 319: Invalid trace entry type thread_exit (23) before a bundle
2024-11-28T03:48:11.0257713Z 319: drmemtrace_launcher: /home/runner/work/dynamorio/dynamorio/clients/drcachesim/reader/reader.cpp:262: virtual bool dynamorio::drmemtrace::reader_t::process_input_entry(): Assertion `type_is_instr(cur_ref_.instr.type) || cur_ref_.instr.type == TRACE_TYPE_INSTR_NO_FETCH' failed.
2024-11-28T03:48:11.0259583Z 320: 
2024-11-28T03:48:11.0259996Z 320:      Finished computing current solution distance in mode 0.
2024-11-28T03:48:11.0260538Z 320:      Mode changed to 0.
2024-11-28T03:48:11.0261378Z 320/515 Test #319: code_api|tool.drcachesim.coherence .................................***Failed  Required regular expression not found. Regex=[^

xref #4673

EDIT: now passing.

@derekbruening
Copy link
Contributor

code_api|tool.drcachesim.coherence failed on ci-x86 / x86-64 (pull_request):

You can see that this failure is not an output mismatch; it is a fatal assert:

Invalid trace entry type thread_exit (23) before a bundle

That's #3320

@edeiana edeiana changed the title i#6662: invariant_checker update i#6662 regdeps: Invariant checks for filetype and cpuid Dec 5, 2024
@edeiana edeiana merged commit 100cac0 into master Dec 5, 2024
17 checks passed
@edeiana edeiana deleted the i6662-regdeps-invariant-checker-update branch December 5, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants