-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i#6662 regdeps: Invariant checks for filetype and cpuid #7100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Public traces (i.e., OFFLINE_FILE_TYPE_ARCH_REGDEPS traces) have a new constraint: TRACE_MARKER_TYPE_CPU_ID values must all be -1 as we don't want to expose a CPU schedule. We add this constraint as invariant in the invariant_checker. We also add an invariant for the trace file type, which should not contain any OFFLINE_FILE_TYPE_ARCH_* information except for OFFLINE_FILE_TYPE_ARCH_REGDEPS. Issue #6662
xref #4673 EDIT: now passing. |
You can see that this failure is not an output mismatch; it is a fatal assert:
That's #3320 |
derekbruening
approved these changes
Dec 2, 2024
edeiana
changed the title
i#6662: invariant_checker update
i#6662 regdeps: Invariant checks for filetype and cpuid
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public traces (i.e., OFFLINE_FILE_TYPE_ARCH_REGDEPS traces) have a new
constraint: TRACE_MARKER_TYPE_CPU_ID values must all be -1 as we don't
want to expose a CPU schedule. We add this constraint as invariant in the
invariant_checker
.We also add an invariant for the trace file type, which should not contain any
OFFLINE_FILE_TYPE_ARCH_* information except for
OFFLINE_FILE_TYPE_ARCH_REGDEPS.
Issue #6662