i#6822 unscheduled: Change infinite to max timeout in scheduler #7016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new drmemtrace scheduler option scheduler_options_t.honor_infinite_timeouts and a CLI parameter -sched_infinite_timeouts, both off by default. If turned on, these match the previous behavior. Changes the default behavior to use the (scaled per the scale parameter) maximum block timeout for indefinitely-unscheduled cases, rather than using an infinite timeout. This avoids waiting a long time for things like background threads that do nothing but wait the entire duration of a trace. Adds unit test variants for both infinite and max-timeout. Tested on a large application where this did not noticeably decrease the successful number of direct switches, but did reduce the idle time which was too high previously. Issue: #6822
brettcoon
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new drmemtrace scheduler option
scheduler_options_t.honor_infinite_timeouts and a CLI parameter -sched_infinite_timeouts, both off by default. If turned on, these match the previous behavior.
Changes the default behavior to use the (scaled per the scale parameter) maximum block timeout for indefinitely-unscheduled cases, rather than using an infinite timeout. This avoids waiting a long time for things like background threads that do nothing but wait the entire duration of a trace.
Adds unit test variants for both infinite and max-timeout.
Tested on a large application where this did not noticeably decrease the successful number of direct switches, but did reduce the idle time which was too high previously.
Issue: #6822