Add support for custom prefetchers in drcachesim #6999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the one failed check is unrelated and is failing without this change as well. It appears that I can't request a review without write access to this repository, but this change should be ready for review. |
brettcoon
requested changes
Sep 21, 2024
Yes, Github jumped doxygen to 1.12 on the Mac VM's which broke the build there: fixed in #7001 |
brettcoon
approved these changes
Sep 23, 2024
|
Perfect, thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add constructors to the cache_simulator_t that accept a custom prefetcher factory argument.
No change to default behavior.
Added unit tests for a custom prefetcher and the existing nextline prefetcher.