Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i#6938 sched migrate: Use annotation for fallthrough #6975

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

derekbruening
Copy link
Contributor

Replaces a comment with an official compiler annotation for a switch case fallthrough, to fix a warning under some compilers as part of running scheduler_unit_tests internally.

Issue: #6938

Replaces a comment with an official compiler annotation for a switch
case fallthrough, to fix a warning under some compilers as part of
running scheduler_unit_tests internally.

Issue: #6938
@edeiana
Copy link
Contributor

edeiana commented Sep 9, 2024

Just noticed: are these failing tests among those that recently started to fail often for AARCH64? (I have not seen them failing personally, so just double checking this change is not the culprit, although it's unlikely as it's not failing to build)

2024-09-09T22:27:00.5769792Z 	code_api|linux.fib-conflict 
2024-09-09T22:27:00.5770504Z 	code_api|linux.fib-conflict-early 
2024-09-09T22:27:00.5771253Z 	code_api|linux.thread-reset 
2024-09-09T22:27:00.5771858Z 	code_api|api.startstop

@derekbruening
Copy link
Contributor Author

The first ones are all ignored (there are layers of scripts and a later ones marks them ignore:

2024-09-09T22:27:00.6058886Z 	(ignore: i#2417) 	code_api|linux.fib-conflict 
2024-09-09T22:27:00.6059837Z 	(ignore: i#2417) 	code_api|linux.fib-conflict-early 
2024-09-09T22:27:00.6060781Z 	(ignore: i#2417) 	code_api|linux.thread-reset 
2024-09-09T22:27:00.6061517Z 	code_api|api.startstop 
2024-09-09T22:27:00.6062369Z 	code_api|api.static_sideline_FLAKY 

So api.startstop is the only failure: I think that is #6928.
These arm suites have been very flaky in the last few weeks with multiple failures: not sure why they seem to be worse than before.

@derekbruening derekbruening merged commit ae6765c into master Sep 10, 2024
16 of 17 checks passed
@derekbruening derekbruening deleted the i5843-annotate-fall-through branch September 10, 2024 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants