i#6977: Fix quantum underflow #6973
Conversation
Fix bug underflowing quantum time when trying to correct overshoot but the quantum just expired and so is 0; or, we're replaying. Adds an assert. A test will come in the forthcoming rebalance test for per-output runqueues, which is where this bug was discovered. Issue: #6938
|
Maybe it is worth filing a separate issue and updating the description to point at it instead of the migrate issue? Ended up finding and fixing these as part of the runqueues and now trying to split out unrelated pieces with minimal effort...it is probably possible to make a smaller separate dedicated test to trigger this instead of only relying on the new larger rebalance test; tradeoffs. |
There was a problem hiding this comment.
Given the complexity of this code and the number of bugs found recently, it certainly seem like more tests would be beneficial. But I don't have a good feel for whether or not it's worth adding a small directed test for this particular problem, assuming a bigger test that's already written will reliably cover it.
derekbruening
changed the title
|
Ended up filing an issue to cover this: #6977 |
|
a64 failure is TLB-threads bundle #3320 |
Fix bug underflowing quantum time when trying to correct overshoot but the quantum just expired and so is 0; or, we're replaying. Adds an assert.
A test will come in the forthcoming rebalance test for per-output runqueues, which is where this bug was discovered.
Fixes #6977