Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i#6733 missing exit: Suppress drmemtrace invariant check #6967

Merged
merged 1 commit into from
Sep 5, 2024
Merged

i#6733 missing exit: Suppress drmemtrace invariant check #6967

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions clients/drcachesim/tools/invariant_checker.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,10 +185,10 @@ invariant_checker_t::parallel_shard_exit(void *shard_data)
per_shard_t *shard = reinterpret_cast<per_shard_t *>(shard_data);
report_if_false(shard,
shard->saw_thread_exit_
// XXX i#6444: For online on some Windows tests we see threads
// XXX i#6733: For online we sometimes see threads
// exiting w/o the tracer inserting an exit. Until we figure
// that out we disable this error for Windows online.
IF_WINDOWS(|| !knob_offline_),
// that out we disable this error to unblock testing.
|| !knob_offline_,
"Thread is missing exit");
if (!TESTANY(OFFLINE_FILE_TYPE_FILTERED | OFFLINE_FILE_TYPE_DFILTERED |
// In OFFLINE_FILE_TYPE_ARCH_REGDEPS we can have leftover
Expand Down
Loading