Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i#5505 kernel tracing: Add flag to configure PT buffer size #6936

Merged
merged 6 commits into from
Aug 26, 2024

Conversation

abhinav92003
Copy link
Contributor

@abhinav92003 abhinav92003 commented Aug 23, 2024

Adds a new drmemtrace command-line flag that allows setting an appropriate size for the buffer used to collect PT kernel trace data during online trace collection: -kernel_trace_buffer_size_shift.

For apps with a high thread count, a large value may cause OOMs. At the same time, a too low value causes issues during trace decode. The new flag allows tuning it as needed.

Verified that the PT related tests continue to work on a system that supports the Intel-PT hardware feature:

The following tests passed:
	code_api|tool.drcacheoff.kernel.simple_SUDO
	code_api|tool.drcacheoff.kernel.opcode-mix_SUDO
	code_api|tool.drcacheoff.kernel.syscall-mix_SUDO
	code_api|tool.drcacheoff.kernel.invariant-checker_SUDO

...

The following tests passed:
	code_api|client.drpttracer_SUDO-test

Issue: #5505

Adds a new drmemtrace command-line flag that allows setting an appropriate size for the buffer used to collect PT data: -pt_ring_buffer_size_shift.

For apps with a high thread count, a large value may cause OOMs. At the same time, a too low value causes issues during trace decode.

Issue: #5505
clients/drcachesim/common/options.cpp Outdated Show resolved Hide resolved
clients/drcachesim/common/options.cpp Outdated Show resolved Hide resolved
clients/drcachesim/common/options.cpp Outdated Show resolved Hide resolved
clients/drcachesim/common/options.cpp Outdated Show resolved Hide resolved
clients/drcachesim/tracer/syscall_pt_trace.h Show resolved Hide resolved
@abhinav92003 abhinav92003 merged commit 4dfe3d9 into master Aug 26, 2024
17 checks passed
@abhinav92003 abhinav92003 deleted the i5505-flag-ring-buffer-size branch August 26, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants