i#6685 core-shard: Add only_shards drmemtrace filter #6925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new filter by shard ordinal to the drmemtrace scheduler and analyzers, and adds multi-thread filtering on the command line. Adds input_workload_t.only_shards to filter scheduler inputs by ordinal, which is mostly useful for core-sharded-on-disk traces. Adds new CLI options -only_shards, which takes a comma-separated list of ordinals, and -only_threads, which takes a comma-separated list of tids. Adds sorting of file names when reading inputs from a directory so that ordinals are reliable. Adds leading 0's to record_filter's output name so this lexicographic sort keeps cores in order. Adds error checking that any tid or ordinal filter is actually present in the inputs. Adds an internal struct input_read_info_t to implement the new filtering inside the scheduler. Adds scheduler unit tests of the new filters. Adds an end-to-end test of -only_shards on a core-sharded-on-disk trace. Also tested end-to-end manually with invalid tids, invalid ordinals, valid tids for core-sharded-on-disk, and valid ordinals for core-sharded-on-disk. Issue: #6685
|
Filed #6928 for the api.startstop a64 failure. This PR does not change core/ so it should have zero effect; should pass on retry. |
brettcoon
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new filter by shard ordinal to the drmemtrace scheduler and analyzers, and adds multi-thread filtering on the command line.
Adds input_workload_t.only_shards to filter scheduler inputs by ordinal, which is mostly useful for core-sharded-on-disk traces.
Adds new CLI options -only_shards, which takes a comma-separated list of ordinals, and -only_threads, which takes a comma-separated list of tids.
Adds sorting of file names when reading inputs from a directory so that ordinals are reliable. Adds leading 0's to record_filter's output name so this lexicographic sort keeps cores in order.
Adds error checking that any tid or ordinal filter is actually present in the inputs.
Adds an internal struct input_read_info_t to implement the new filtering inside the scheduler.
Adds scheduler unit tests of the new filters.
Adds an end-to-end test of -only_shards on a core-sharded-on-disk trace.
Also tested end-to-end manually with invalid tids, invalid ordinals, valid tids for core-sharded-on-disk, and valid ordinals for core-sharded-on-disk.
Issue: #6685