Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i#3544 RV64: Enable the build of the drcov test for RV64 #6904

Merged
merged 7 commits into from
Aug 15, 2024

Conversation

chenhy0106
Copy link
Contributor

@chenhy0106 chenhy0106 commented Jul 29, 2024

  1. Enable the document generation for drcov2lcov options as RISC-V binaries now work.
  2. Enable the build of the drcov test linux.eintr for RISC-V. This test can be built and runs correctly on the physical machine. However, due to qemu issues, it cannot be added to the RUNS_ON_QEMU list for RISC-V now.

Issue: #3544

@chenhy0106 chenhy0106 requested review from derekbruening and ksco July 29, 2024 14:58
ksco
ksco previously approved these changes Jul 29, 2024
Copy link
Contributor

@ksco ksco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, does these newly opened tests checked by CI? We need to add them to RUNS_IN_QEMU for that, right?

@ksco ksco dismissed their stale review July 29, 2024 22:33

Dismissed outdated review

clients/drcov/CMakeLists.txt Show resolved Hide resolved
@chenhy0106 chenhy0106 changed the title i#3544 RV64: Open drcov test for RV64 i#3544 RV64: Enable to build drcov test for RV64 Aug 12, 2024
@chenhy0106 chenhy0106 changed the title i#3544 RV64: Enable to build drcov test for RV64 i#3544 RV64: Enable the build of the drcov test for RV64 Aug 12, 2024
@chenhy0106
Copy link
Contributor Author

chenhy0106 commented Aug 12, 2024

Wait, does these newly opened tests checked by CI? We need to add them to RUNS_IN_QEMU for that, right?

Only build the eintr test without adding it to RUNS_IN_QEMU. Currently, tests that involve creating threads with clone do not seem to pass under qemu-riscv64.

Testing on the physical machine works fine.

suite/tests/CMakeLists.txt Show resolved Hide resolved
suite/tests/CMakeLists.txt Show resolved Hide resolved
@chenhy0106 chenhy0106 merged commit 50f4e6e into DynamoRIO:master Aug 15, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants