i#6844: Add times_of_interest to drmemtrace scheduler #6845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new feature times_of_interest to the drmemtrace scheduler. This allows specifying regions of interest via timestamps, which cut across all inputs in a workload, providing for a consistent starting point across all threads. The feature requires a cpu schedule file which is used to build a mapping from timestamps to instruction ordinals. The mapping is not perfect due to collapsed consecutive entries and coarse-grained timestamps so interpolation is used in between known points. Adds a unit test. Adds a new analyzer command-line option -skip_to_timestamp which sets a single time-of-interest in the scheduler. Adds a test using the checked-in threadsig x86_64 trace. Fixes #6844
|
a64-sve failure is the known invariants test "missing exit" no one has figured out: #6733 |
derekbruening
commented
Jun 14, 2024
abhinav92003
approved these changes
Jun 14, 2024
…valid_input_count_, etc.: but feeling like a losing battle; probably have to abandon
… ROI to the max limit (and downgrade a max-limit-ish skip to a non-user-error): much simpler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new feature times_of_interest to the drmemtrace scheduler. This allows specifying regions of interest via timestamps, which cut across all inputs in a workload, providing for a consistent starting point across all threads.
The feature requires a cpu schedule file which is used to build a mapping from timestamps to instruction ordinals. The mapping is not perfect due to collapsed consecutive entries and coarse-grained timestamps so interpolation is used in between known points.
Adds a unit test.
Adds a new analyzer command-line option -skip_to_timestamp which sets a single time-of-interest in the scheduler. Adds a test using the checked-in threadsig x86_64 trace.
Fixes #6844