i#6662 public traces, part 5: func_id_filter_t #6820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The public version of a trace needs to preserve the TRACE_MARKER_TYPE_FUNC_[ID | ARG | RETVAL] markers related to SYS_futex system calls. We add this feature to encodings2regdeps_filter_t. This filter still drops the TRACE_MARKER_TYPE_FUNC_ markers related to other functions that are not SYS_futex. However, we still rely on type_filter_t to remove the additional markers that we don't want to preserve in the public trace. Issue #6662
in order to run this test there.
derekbruening
requested changes
May 21, 2024
encodings2regdeps_filter_t.
edeiana
changed the title
edeiana
changed the title
derekbruening
approved these changes
Jun 5, 2024
|
No the other file options.cpp is for all tools and should keep the comment.
…On Thu, Jun 6, 2024 at 12:59 AM Enrico Deiana ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In clients/drcachesim/tools/record_filter_launcher.cpp
<#6820 (comment)>:
> "the encoding of instructions from a real ISA to the DR_ISA_REGDEPS synthetic ISA.");
+
+/* XXX i#6369: we should partition our options by tool. This one should belong to the
Got it, removed, also from the other file.
—
Reply to this email directly, view it on GitHub
<#6820 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABRVIMXRLA45LGUB3DL7MELZF7UE3AVCNFSM6AAAAABIAUBLDCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCMBQG44TSMJXGQ>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new filter:
func_id_filter_tto record_filter, which filters TRACE_MARKER_TYPE_FUNC_ markers based on the function ID.The filter is enabled by
-filter_keep_func_idsfollowed by a list of integers that represent the function IDs bound to TRACE_MARKER_TYPE_FUNC_ markers to keep in the trace.Specifically, whenever we encounter a TRACE_MARKER_TYPE_FUNC_ID marker whose marker value is in the list we set a per-shard flag to indicate that all TRACE_MARKER_TYPE_FUNC_[ID | ARG | RETVAL | RETADDR] markers related to that function ID need to be preserved. We remove the TRACE_MARKER_TYPE_FUNC_ markers related to functions whose ID is not in the list.
This filter can be invoked with:
To preserve TRACE_MARKER_TYPE_FUNC_ markers related to functions with ID: 1, 2, 3, 4, and remove the TRACE_MARKER_TYPE_FUNC_ markers for all other ID values.
We use this filter to preserve markers related to SYS_futex functions in the public release of traces.
Issue #6662