i#3544 RV64: Optimize private memcpy and memset #6800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Refer to musl lib to optimize private memcpy and memset. 2. Add test to compare private and libc memset. 3. Compare our memcpy with libc memcpy on more small sizes. 4. Fix a bug of core/CMakeLists.txt. For unit_tests, to compare private and libc memcpy, we should link unit_tests to drmemfuncs but not link to libc. Issue: DynamoRIO#3544
derekbruening
requested changes
May 8, 2024
derekbruening
approved these changes
May 9, 2024
ksco
reviewed
May 10, 2024
|
The newly committed comments look good to me, and PR is approved, I'm going to merge this. Thanks. |
ksco
added a commit
that referenced
this pull request
Jul 11, 2024
We optimized RV64 memfuncs in PR #6800. However, there was a mistake where the return value of memcpy was incorrectly set to ARG2 which led to segfaults in the release build. This PR addresses this issue. Additionally, our unit_tests did not catch this error because `ret = our_memcpy(&i, &j, sizeof(i));` was optimized by the compiler to `i = j; ret = &i;`. We resolved this by utilizing the `noinline` attribute.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compare original memcpy&memset, optimized private memcpy&memset and glibc memcpy&memset.
Test command:
When we use original memcpy and memset, outputs:
When we use optimized memcpy and memset, outputs:
Issue: #3544