i#5036 A64 scatter/gather, part 1: Expand scalar+vector loads #6267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7f939de. It broke native builds where SVE is not supported by the hardware.
There was a problem hiding this comment.
Probably @abhinav92003 should take a look as the x86 scatter/gather author. I did not finish the long suite/tests/client-interface/drx-scattergather-aarch64.cpp file but sending out what I have; mostly minor style nits.
jackgallagher-arm
changed the title
Change-Id: I63b50ee4372f1810df6a80b7faecdeacab61dac8
abhinav92003
approved these changes
Aug 18, 2023
Change-Id: Iacb7f17fea5663ed7734680eb87f2f7dd8f16905
…d-scatter-gather-part1 Change-Id: Ib55d689c5f7935220fcd6d3d7c7a5ea4062bab6d
|
@derekbruening, @abhinav92003: I think I have addressed all your comments. Are you happy for me to merge this PR now? Thanks |
abhinav92003
approved these changes
Aug 23, 2023
derekbruening
approved these changes
Aug 23, 2023
jackgallagher-arm
changed the title
Change-Id: Id2092053b1ad0988a9fa5e5c8e8afae47ef7dd7c
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
jackgallagher-arm
deleted the
i5844-aarch64-expand-scatter-gather-part1
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates an AArch64 version of drx_expand_scatter_gather() and tests for it. So far only SVE scalar+vector loads are supported. Support and tests for more instructions will follow in future commits.
State restore is also not yet supported and will be implemented when i#5365 is complete.
Issue: #5036