i#5843 scheduler: Add replay of the as-traced schedule #6045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds replay of the as-traced schedule using the cpu_schedule.zip file written by raw2trace. That file is converted into the record+replay format for dynamic schedules and the existing replay code leveraged. This implements as-traced cpu-oriented parallel iteration in the scheduler which is part of #5694. Adding analysis tool support for this will be done separately. Updates all replays (whether as-traced or as-previously) to consider DEPENDENCY_TIMESTAMPS to indicate whether to have one output wait if it gets ahead of another's timestamp. Adds a missing check for output count mismatches on as-previously replay. Issue: #5843, #5694
… so we can delete w/o affecting compatibility
abhinav92003
approved these changes
May 15, 2023
…tion; s/map/set/; rename iterator vars; augment several comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds replay of the as-traced schedule using the cpu_schedule.zip file written by raw2trace. That file is converted into the record+replay format for dynamic schedules and the existing replay code leveraged.
This implements as-traced cpu-oriented parallel iteration in the scheduler which is part of #5694. Adding analysis tool support for this will be done separately.
Updates all replays (whether as-traced or as-previously) to consider DEPENDENCY_TIMESTAMPS to indicate whether to have one output wait if it gets ahead of another's timestamp.
Removes STATUS_IDLE since we always use STATUS_WAIT. We're between releases so we can delete from the public enum for this still-under-development component without worrying about binary compatibility.
Adds a missing check for output count mismatches on as-previously replay.
Adds unit tests of synthetic and from-file replay.
Issue: #5843, #5694