i#5953 rseq: Fix rseq adjust issues with filtering #5971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes problems with the new rseq adjustment code with filtered traces: + Load and update the buffer pointer when emitting the rseq entry label + Do not try to adjust for i-filtered Adds 2 new tests for filtering the linux.rseq app. The new tests revealed a problem with the instr counts in the schedule file: raw2trace was counting the PC-only entries as instructions; we fix that here. Issue: #5953
PC for a signal in the instrumented execution. Leaves all other cases (all aborts in the native execution) as the handler. This lets us properly place the abort+signal for the instrumented interruption case. Adjusts the invariant checker abort check to use the new end PC for a more accurate test to avoid false positives and negatives.
|
x64 failure is raw-zlib: known zlib stability issue: #5635 |
abhinav92003
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes problems with the new rseq adjustment code with filtered traces:
Adds 2 new tests for filtering the linux.rseq app.
The new tests revealed a problem with the instr counts in the schedule file:
raw2trace was counting the PC-only entries as instructions; we fix that here.
Reverts the rseq abort event and marker value back to the interrupted
PC for a signal in the instrumented execution. Leaves all other cases
(all aborts in the native execution) as the handler. This lets us
properly place the abort+signal for the instrumented interruption
case.
Adjusts the invariant checker abort check to use the new end PC for a
more accurate test to avoid false positives and negatives.
Fixes #5953, #4041