i#5538 memtrace seek, part 11: Fix omitted header problems #5840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug where reader_t's detection of duplicated timestamp,cpuid headers at the start of a chunk assumed single-threaded mode. We switch to using a simple per-tid chunk footer trigger. Adds a test to view_test via a new serial mock which takes in trace_entry_t and allows testing of the interleaving code. Tests both proper chunk header elision as well as replicating the bug where elision should not happen. The test revealed a separate bug in the view tool where the version and filetype ordinals, for delaying, were not updated on new threads. That is fixed here as well as otherwise the new tests fail. Issue: #5538
hidden markers at the start of a chunk when skipping in a zipfile as well as in raw2trace.
bete0
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where reader_t's detection of duplicated timestamp,cpuid headers at the start of a chunk assumed single-threaded mode. We switch to using a simple per-tid chunk footer trigger.
Adds a test to view_test via a new serial mock which takes in trace_entry_t and allows testing of the interleaving code. Tests both proper chunk header elision as well as replicating the bug where elision should not happen.
The test revealed a separate bug in the view tool where the version and filetype ordinals, for delaying, were not updated on new threads. That is fixed here as well as otherwise the new tests fail.
Issue: #5538