i#5675: Fix data race in record_filter. #5772
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a race in updating input_entry_count_ and output_entry_count_
in parallel_shard_exit in the record_filter analyzer.
Moves aggregation logic to print_results instead. Like other analyzers,
we now keep track of all shard data pointers and free them in the
destructor instead. We destroy the writer object in parallel_shard_exit
itself though, for symmetry with how it's created (in parallel_shard_stream_init)
and so that users don't have to destroy the record_filter_t object itself
for output files to be written out.
Issue: #5675