Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i#5675: Fix data race in record_filter. #5772

Merged
merged 5 commits into from
Dec 2, 2022

Conversation

abhinav92003
Copy link
Contributor

@abhinav92003 abhinav92003 commented Dec 2, 2022

Fixes a race in updating input_entry_count_ and output_entry_count_
in parallel_shard_exit in the record_filter analyzer.

Moves aggregation logic to print_results instead. Like other analyzers,
we now keep track of all shard data pointers and free them in the
destructor instead. We destroy the writer object in parallel_shard_exit
itself though, for symmetry with how it's created (in parallel_shard_stream_init)
and so that users don't have to destroy the record_filter_t object itself
for output files to be written out.

Issue: #5675

Fixes a race in updating the input_entry_count_ and output_entry_count_
in parallel_shard_exit in the record_filter analyzer.
@abhinav92003
Copy link
Contributor Author

Created #5774 for the AArch64 failure. It's definitely unrelated to this PR.

@abhinav92003 abhinav92003 changed the title Fix data race in record_filter. i#5675: Fix data race in record_filter. Dec 2, 2022
@abhinav92003 abhinav92003 merged commit eb70ae0 into master Dec 2, 2022
@abhinav92003 abhinav92003 deleted the iX-fix-record-filter-race branch December 2, 2022 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants