i#5675 record filter: Improve interfaces. #5751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improves interfaces to allow use in 3rd party code. Uses std::unique_ptr for the record_filter_func_t vector and for the input file in record_file_reader_t. Adjusts record_filter_launcher and record_filter_unit_tests to pass unique_ptrs now. Make input_entry_count_ and output_entry_count_ protected to let them be accessed by derived classes. Separates out the cache_filter implementation details into a cpp file to obviate the need to transitively include cache_lru.h Issue: #5675
|
x86-32 failure is #4604. |
derekbruening
approved these changes
Nov 21, 2022
|
Jenkins failure is #5635. |
|
run arm tests |
1 similar comment
|
run arm tests |
|
Jenkins now hit #5484. |
|
run arm tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves interfaces to allow use in 3rd party code.
Uses std::unique_ptr for the record_filter_func_t vector and for the input file in record_file_reader_t. Adjusts record_filter_launcher and record_filter_unit_tests to pass unique_ptrs now.
Make input_entry_count_ and output_entry_count_ protected to let them be accessed by derived classes.
Separates out the cache_filter implementation details into a cpp file.
Adds the drcachesim/simulator directory to includes.
Issue: #5675