i#5538 memtrace seek, part 9: Add accurate record count #5737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a reader subclass to raw2trace for computing the memref_t record count for each chunk. A new marker is inserted in the chunk header which the zipfile skip code uses to obtain the correct ref count when skipping over chunks. Adds a count suppression feature where the view tool prints 0 for the record count for the synthetic timestamp+cpu added after a seek. Updates the seek test with a new trace and new expected output. Issue: #5538
|
I keep hitting discrepancies between clang-format and clang-format-diff. Both are 14 so I don't think it's a version issue. We've seen this many times in the past as well. Not sure there is a good solution -- other than changing our clang-format check to run on the full file somehow. |
abhinav92003
approved these changes
Nov 15, 2022
…to look at trace_entry_t, which overall is simpler; update test trace for this
derekbruening
added a commit
that referenced
this pull request
Nov 17, 2022
Adds a reader subclass to raw2trace for computing the memref_t record count for each chunk. A new marker is inserted in the chunk header which the zipfile skip code uses to obtain the correct ref count when skipping over chunks. Adds a count suppression feature where the view tool prints 0 for the record count for the synthetic timestamp+cpu added after a seek. Updates the seek test with a new trace and new expected output. Issue: #5538
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a reader subclass to raw2trace for computing the memref_t record count for each chunk. A new marker is inserted in the chunk header which the zipfile skip code uses to obtain the correct ref count when skipping over chunks.
Adds a count suppression feature where the view tool prints 0 for the record count for the synthetic timestamp+cpu added after a seek.
Updates the seek test with a new trace and new expected output.
Issue: #5538