i#5538 memtrace seek, part 7: Add instr count to tools #5721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new memref_stream_t interface class which provides the record and instruction count to drmemtrace analysis tools. A pointer to this interface is passed to new extended-argument versions of analysis_tool_t's initialize() and parallel_shard_init() functions, which are now what is called by the analyzer. The base class implementation of these new functions simply calls the old versions, which are now deprecated but will continue to work. This new interface is not just for convenience: the tool itself cannot accurately count when the reader skips over records, as will happen with seeking. The counting must be done in the reader. (If the tool indeed wants to count only records/instrs that it actually sees, it can continue using its own counters.) Updates the view tool to use the new interface to obtain the record ordinal, replacing its own counter. The tool is expanded to print a new column with the instruction ordinal. The view tool test is updated along with example output in the docs. Issue: #5538
…/stream/; Fix phys test output; Add to release notes
abhinav92003
approved these changes
Nov 9, 2022
Add discussion of other options, to be added to the commit descr too: We had considered other avenues for analysis_tool_t to obtain things like the record and instruction ordinals within the stream, in the presence of skipping: we could add fields to memref but we'd either have to append and have them at different offsets for each type or we'd have to break compatbility to prepend every time we added more; or we could add parameters to process_memref(). Passing an interface to the init routines seems the simplest and most flexible.
|
a64 failure is windows-zlib #5493 |
|
run arm tests |
1 similar comment
|
run arm tests |
|
Hit an invariant check failure on chunk instr counts: this was hit once before on a64 and I couldn't reproduce it. Filed #5724 now. |
|
run arm tests |
|
Failed again on a64 invariant_checker...yet when I log in to the machine and run the test in a loop it passes every time. Given that it failed once before this PR and passed in earlier checks I am convinced it is not related to this PR itself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new memref_stream_t interface class which provides the record and instruction count to drmemtrace analysis tools. A pointer to this interface is passed to new extended-argument versions of analysis_tool_t's initialize() and parallel_shard_init() functions, which are now what is called by the analyzer. The base class implementation of these new functions simply calls the old versions, which are now deprecated but will continue to work.
This new interface is not just for convenience: the tool itself cannot accurately count when the reader skips over records, as will happen with seeking. The counting must be done in the reader. (If the tool indeed wants to count only records/instrs that it actually sees, it can continue using its own counters.)
Updates the view tool to use the new interface to obtain the record ordinal, replacing its own counter. The tool is expanded to print a new column with the instruction ordinal. The view tool test is updated along with example output in the docs.
Issue: #5538