i#5538 memtrace seek, part 3: Add reader buffering #5640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds buffering to the zipfile reader, which eliminates the 60% slowdown it showed compared to our gzip reader and in fact results in faster read times than the gzip reader. Adds similar buffering to the gzip reader, which results in an 18% speedup and matches the new zipfile speed. Issue: #5538
abhinav92003
approved these changes
Sep 8, 2022
abhinav92003
reviewed
Sep 8, 2022
derekbruening
changed the title
|
The failure is the drcachesim.invariants test #5636 for which I have an imminent fix. Unrelated to this PR. |
dolanzhao
pushed a commit
that referenced
this pull request
Sep 12, 2022
Adds buffering to the zipfile reader, which eliminates the 60% slowdown it showed compared to our gzip reader and in fact results in faster read times than the gzip reader. Adds similar buffering to the gzip reader, which results in an 18% speedup and matches the new zipfile speed. Issue: #5538
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds buffering to the zipfile reader, which eliminates the 60% slowdown it showed compared to our gzip reader and in fact results in faster read times than the gzip reader.
Adds similar buffering to the gzip reader, which results in an 18% speedup and matches the new zipfile speed.
Issue: #5538