i#3995 multi-window: Write separate raw files per window #5450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a drmemtrace feature under a new on-by-default -split_windows option to create a separate subdirectory with a separate set of raw files per traced window. This avoids disk space issues with a single file, and splitting at the raw stage is relatively simple for regular drmemtrace usage (though not as simple for external users of the file i/o redirection). Files in raw/window.NNNN/ subdirectories are mirrored in trace/window.NNNN/ subdirectories upon being post-processed. Post-processing handles just the first window by default; the others must be explicitly passed as input directories in separate post-processing invocations. This changes the non-window behavior to not create an output file until tracing starts, which necessitated changing the tool.drcacheoff.delay-func test to check for no output files as a slightly different type of test. Adds a test of split-file offline windows. Fixes an infinite loop bug in raw2trace hit when a file is truncated: hit while the windows were buggy and missing footers. Issue: #3995
bete0
approved these changes
Apr 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a drmemtrace feature under a new on-by-default -split_windows
option to create a separate subdirectory with a separate set of raw
files per traced window. This avoids disk space issues with a single
file, and splitting at the raw stage is relatively simple for regular
drmemtrace usage (though not as simple for external users of the file
i/o redirection).
Files in raw/window.NNNN/ subdirectories are mirrored in
trace/window.NNNN/ subdirectories upon being post-processed.
Post-processing handles just the first window by default; the others
must be explicitly passed as input directories in separate
post-processing invocations.
This changes the non-window behavior to not create an output file
until tracing starts, which necessitated changing the
tool.drcacheoff.delay-func test to check for no output files as a
slightly different type of test.
Adds a test of split-file offline windows.
Fixes an infinite loop bug in raw2trace hit when a file is truncated:
hit while the windows were buggy and missing footers.
Issue: #3995