Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i#5195 win2019: Fix except-execution test #5414

Merged
merged 6 commits into from
Mar 12, 2022

Conversation

derekbruening
Copy link
Contributor

Updates the security-win32.except-execution test to not make a raw
thread with a custom stack, which fails on GA CI win2019. Running the
test code on the initial thread as-is works fine, for regular DR
instrumentation modes.

To avoid headaches with tabs and trailing spaces, updates the context
dumping to avoid those, and updates other templates that use that.

Issue: #5195

Updates the security-win32.except-execution test to not make a raw
thread with a custom stack, which fails on GA CI win2019.  Running the
test code on the initial thread as-is works fine, for regular DR
instrumentation modes.

To avoid headaches with tabs and trailing spaces, updates the context
dumping to avoid those, and updates other templates that use that.

Issue: #5195
@derekbruening
Copy link
Contributor Author

OK confirmed it's fixed for VS2019:

debug-internal-32: 243 tests passed, **** 6 tests failed, but ignoring 4 for i#2145: ****
	(ignore: i#2145) 	code_api|win32.hookerfirst 
	(ignore: i#2145) 	code_api|client.drx-test 
	code_api|client.tls 
	code_api|client.drsyms-test 
	(ignore: i#2145) 	code_api|client.pcache-use 
	(ignore: i#2145) 	code_api|client.drwrap-test-detach 

@derekbruening
Copy link
Contributor Author

I'll revert the ci-windows.yml and runsuite.cmake changes right before merging. All jobs will fail then b/c of the tabs in the old file (but at least any future changes won't have to deal with that) and I'll have to do an override-merge.

@derekbruening derekbruening merged commit 6482e57 into master Mar 12, 2022
@derekbruening derekbruening deleted the i5195-except-execution-test branch March 12, 2022 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants