i#1807: Ignore long suite flaky failures to get it green #5342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds ignore rules for the following observed long suite failures, keeping some of them limited to the long suite only so we do not lose the ability to detect fails-every-time breakage in pull requests: + #2052: signal.c:5306 tr == NULL || tr->under_dynamo_control || IS_CLIENT_THREAD(dcontext) || sig == SUSPEND_SIGNAL + lin64 prof_pcs|common.nativeexec_exe_opt https://github.com/DynamoRIO/dynamorio/runs/5079862873 + lin32 prof_pcs|common.nativeexec_retakeover_opt https://github.com/DynamoRIO/dynamorio/runs/5080176761 + lin64 prof_pcs,thread_private|common.nativeexec_exe_opt https://github.com/DynamoRIO/dynamorio/runs/4992456119 + lin32 prof_pcs,thread_private|common.nativeexec_bindnow_opt https://github.com/DynamoRIO/dynamorio/runs/4993095901 + lin32 prof_pcs|common.nativeexec_bindnow_opt https://github.com/DynamoRIO/dynamorio/runs/4860096547 https://github.com/DynamoRIO/dynamorio/runs/4792339299 + #4732: client.winxfer test output does not always match + win32 code_api|client.winxfer https://github.com/DynamoRIO/dynamorio/runs/5113993573 https://github.com/DynamoRIO/dynamorio/runs/5014069363 https://github.com/DynamoRIO/dynamorio/runs/4860068689 https://github.com/DynamoRIO/dynamorio/runs/4836923113 https://github.com/DynamoRIO/dynamorio/runs/4818620705 + #2657: ASSERT interp.c:5447 t->bbs != NULL in drx_buf-test + lin64 code_api|client.drx_buf-test https://github.com/DynamoRIO/dynamorio/runs/5014069596 + #3320: ASSERT type_is_instr in multiple drcachesim tests + win64 code_api|tool.drcachesim.threads-with-config-file https://github.com/DynamoRIO/dynamorio/runs/4993095937 + win32 code_api|tool.drcachesim.invariants https://github.com/DynamoRIO/dynamorio/runs/4798976751 https://github.com/DynamoRIO/dynamorio/runs/4780921079 Issue: #2052, #4732, #2657, #3320, #1807
abhinav92003
approved these changes
Feb 9, 2022
| $ignore_failures_64{'code_api|tool.drcachesim.simple-config-file'} = 1; # i#1807 | ||
| $ignore_failures_32{'code_api|tool.drcachesim.invariants'} = 1; # i#3320 | ||
| $ignore_failures_32{'code_api|tool.drcachesim.threads-with-config-file'} = 1; # i#3320 | ||
| $ignore_failures_32{'code_api|tool.drcachesim.simple-config-file'} = 1; # i#3320 |
There was a problem hiding this comment.
This one isn't listed in the PR description.
There was a problem hiding this comment.
Right, I extrapolated to cover similar failures in other arch/op combos to try and avoid future redness on variants. Will update the description on merge.
| 'prof_pcs|common.nativeexec_retakeover_opt' => 1, # i#2052 | ||
| 'prof_pcs|common.nativeexec_bindnow_opt' => 1, # i#2052 | ||
| 'prof_pcs,thread_private|common.nativeexec_exe_opt' => 1, # i#2052 | ||
| 'prof_pcs,thread_private|common.nativeexec_retakeover_opt' => 1, # i#2052 |
There was a problem hiding this comment.
This one isn't present in the PR description with the thread_private option.
There was a problem hiding this comment.
Right,, like above, I extrapolated to cover similar failures in other arch/op combos to try and avoid future redness on variants. Will update the description on merge.
|
32-bit x86 failure is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ignore rules for the following observed long suite failures,
keeping some of them limited to the long suite only so we do not lose
the ability to detect fails-every-time breakage in pull requests:
ASSERT signal.c:4224 in prof_pcs nativeexec test #2052: signal.c:5306 tr == NULL || tr->under_dynamo_control || IS_CLIENT_THREAD(dcontext) || sig == SUSPEND_SIGNAL
https://github.com/DynamoRIO/dynamorio/runs/5079862873
https://github.com/DynamoRIO/dynamorio/runs/5080176761
https://github.com/DynamoRIO/dynamorio/runs/4992456119
https://github.com/DynamoRIO/dynamorio/runs/4993095901
https://github.com/DynamoRIO/dynamorio/runs/4860096547
https://github.com/DynamoRIO/dynamorio/runs/4792339299
client.winxfer test output does not always match #4732: client.winxfer test output does not always match
https://github.com/DynamoRIO/dynamorio/runs/5113993573
https://github.com/DynamoRIO/dynamorio/runs/5014069363
https://github.com/DynamoRIO/dynamorio/runs/4860068689
https://github.com/DynamoRIO/dynamorio/runs/4836923113
https://github.com/DynamoRIO/dynamorio/runs/4818620705
ASSERT interp.c:5447 t->bbs != NULL in drx_buf-test #2657: ASSERT interp.c:5447 t->bbs != NULL in drx_buf-test
https://github.com/DynamoRIO/dynamorio/runs/5014069596
ASSERT type_is_instr in multiple drcachesim tests (tool.reuse_distance,tool.drcachesim.warmup-zeros,tool.drcachesim.missfile) on appveyor #3320: ASSERT type_is_instr in multiple drcachesim tests
https://github.com/DynamoRIO/dynamorio/runs/4993095937
https://github.com/DynamoRIO/dynamorio/runs/4798976751
https://github.com/DynamoRIO/dynamorio/runs/4780921079
Issue: #2052, #4732, #2657, #3320, #1807