Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i#1807 long failures: List 8 long suite tests as flaky #5264

Merged
merged 2 commits into from
Dec 21, 2021

Conversation

derekbruening
Copy link
Contributor

Adds the following tests to the ignore list in order to keep the long
suite on master merges greener:

Only ignored in the long suite since these are tests we don't want to
completely break:

Issue: #1807, #2267, #2052, #4604, #5123

Adds the following tests to the ignore list in order to keep the long
suite on master merges greener:

+ win64 'common.floatpc_xl8all' #2267
+ win64 'code_api|tool.drcachesim.simple-config-file' #1807
+ lin32 'code_api,opt_speed|common.fib' #1807
+ lin32 'prof_pcs|common.nativeexec_exe_opt' #2052
+ lin64 'code_api,opt_speed|common.floatpc_xl8all' #1807

Only ignored in the long suite since these are tests we don't want to
completely break:

+ lin32 'code_api|api.startstop' #4604
+ lin64 'code_api|api.detach_state' #5123
+ lin64 'code_api|client.cleancallsig' #1807

Issue: #1807, #2267, #2052, #4604, #5123
@derekbruening
Copy link
Contributor Author

Hmm, this PR ignores lin32 api.startstop failures in the long suite only: but here in the short suite we hit #4604 again. Should we put it on the ignore list for PR's too for lin32??

@abhinav92003
Copy link
Contributor

Hmm, this PR ignores lin32 api.startstop failures in the long suite only: but here in the short suite we hit #4604 again. Should we put it on the ignore list for PR's too for lin32??

As the PR description says, this is one of the important ones. So if there's flakiness in the PR suite, let's not ignore that. Better to ignore only in the long suite.

@abhinav92003
Copy link
Contributor

For now, I guess just a re-run might do.

Do you have any guesses on the root-cause? If this is high priority, I can try solving it this/next week.

@derekbruening
Copy link
Contributor Author

For now, I guess just a re-run might do.

In progress.

Do you have any guesses on the root-cause? If this is high priority, I can try solving it this/next week.

Actually for this one I reproduced on my old laptop and meant to try to debug it but never had time:
#4604 (comment)
Have not yet tried on the new one.
Sure, if you can reproduce, that would be good. #5123 is the other one I'm worried about, but I can't repro that one.

@derekbruening derekbruening merged commit 948a28c into master Dec 21, 2021
@derekbruening derekbruening deleted the i1807-flaky-long-suite branch December 21, 2021 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants