-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i#2974 trace support for AArch64, part 2: added trace implementation #5045
Changes from 15 commits
f29a4da
8a14b7b
7b5b87d
d0a5ff4
fc4fdd4
e6d9fd6
b9ada87
e5b89cb
5b20ed0
d09d2c9
88c535d
ed826fd
6c7cf64
a2047ba
fc70e80
0d456fa
4dffc58
3012697
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2196,6 +2196,14 @@ int | |
append_trace_speculate_last_ibl(dcontext_t *dcontext, instrlist_t *trace, | ||
app_pc speculate_next_tag, bool record_translation); | ||
|
||
/* XXX i#5062 In the long term we should have this only called in mangle_trace() | ||
* and it should be removed from here. | ||
*/ | ||
#ifdef AARCH64 | ||
int | ||
fixup_indirect_trace_exit(dcontext_t *dcontext, instrlist_t *trace); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. See below: long-term this should only be inside mangle_trace() and so this would be removed when #5062 is implemented. Please add a There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. done There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Instead of 'here', maybe mention |
||
#endif | ||
|
||
uint | ||
forward_eflags_analysis(dcontext_t *dcontext, instrlist_t *ilist, instr_t *instr); | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that the ", part N: " is a convention for merges to master: i.e., this PR being merged will be part 1; the next PR for trace building merged into master would be part 2 (not part 19 or sthg: the PR-internal ones don't count toward the master merges).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, that's why I put part 2 in my final commit message above. Have a look if you want and see if there is anything missing or not quite right.