-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify drreg state restoration code. #4976
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rearranges some code to obviate the need for the *_now variables. This is in preparation for sending the i#4963 fix for review. Split out this harmless refactor to make review easier for the fix.
abhinav92003
changed the title
iX: Simply drreg state restoration code.
iX: Simplify drreg state restoration code.
Jun 29, 2021
AArch64 failure is |
x86-32 failure is |
abhinav92003
changed the title
iX: Simplify drreg state restoration code.
Simplify drreg state restoration code.
Jun 30, 2021
derekbruening
approved these changes
Jun 30, 2021
run arm tests |
|
run arm tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rearranges some code to obviate the need for the *_now variables. Also separates out the common instr-is-meta check to an outer if-condition.
This is in preparation for sending the i#4963 fix for review. Split out this harmless refactor to make review easier for that fix.
Issue: #4963