Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify drreg state restoration code. #4976

Merged
merged 4 commits into from
Jun 30, 2021

Conversation

abhinav92003
Copy link
Contributor

@abhinav92003 abhinav92003 commented Jun 29, 2021

Rearranges some code to obviate the need for the *_now variables. Also separates out the common instr-is-meta check to an outer if-condition.

This is in preparation for sending the i#4963 fix for review. Split out this harmless refactor to make review easier for that fix.

Issue: #4963

Rearranges some code to obviate the need for the *_now variables.

This is in preparation for sending the i#4963 fix for review. Split out this harmless refactor to make review easier for the fix.
@abhinav92003 abhinav92003 changed the title iX: Simply drreg state restoration code. iX: Simplify drreg state restoration code. Jun 29, 2021
@abhinav92003
Copy link
Contributor Author

AArch64 failure is code_api|tool.drcachesim.threads-with-config-file#4954.

@abhinav92003
Copy link
Contributor Author

x86-32 failure is code_api|tool.drcacheoff.burst_threads, which is #4963 itself.

ext/drreg/drreg.c Show resolved Hide resolved
ext/drreg/drreg.c Outdated Show resolved Hide resolved
ext/drreg/drreg.c Show resolved Hide resolved
ext/drreg/drreg.c Outdated Show resolved Hide resolved
@abhinav92003 abhinav92003 changed the title iX: Simplify drreg state restoration code. Simplify drreg state restoration code. Jun 30, 2021
@abhinav92003
Copy link
Contributor Author

run arm tests

@abhinav92003
Copy link
Contributor Author

code_api|tool.drcachesim.threads-with-config-file failure on AArch64 again.

@abhinav92003
Copy link
Contributor Author

run arm tests

@abhinav92003 abhinav92003 merged commit 51e5f9c into master Jun 30, 2021
@abhinav92003 abhinav92003 deleted the iX-simplify-drreg-state-restore branch June 30, 2021 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants