i#4425: handle unspecified-by-the-app sigaction restorer for AArch64 #4840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents a seg fault in the burst_aarch64_sys test that was caused by reading an unspecified sigaction restorer in sig_has_restorer() in unix/signal.c. Does so by returning false early in sig_has_restorer() for AArch64 when the SA_RESTORER flag is not set. By preventing the seg fault, it also prevents the nested signal handling and consequently the stack overflow in burst_aarch64_sys. Issue: #4425
derekbruening
approved these changes
Apr 6, 2021
| // XXX i#4425: Fix debug-build stack overflow issue and | ||
| // remove custom signal_stack_size below. | ||
| "-stderr_mask 0xc -signal_stack_size 64K " | ||
| "-stderr_mask 0xc " |
There was a problem hiding this comment.
Could be joined with the next line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents a seg fault in the burst_aarch64_sys test that was caused by reading an unspecified
sigaction restorer in sig_has_restorer() in unix/signal.c. Does so by returning false early
in sig_has_restorer() for AArch64 when the SA_RESTORER flag is not set.
By preventing the seg fault, it also prevents the nested signal handling and consequently
the stack overflow in burst_aarch64_sys test when the -signal_stack_size is not specified.
Issue: #4425