i#4774: Add preferred base to DR and drmodtrack interfaces #4775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a preferred_base field to the module_data_t struct. There is no compatibility break as DR allocates all such structs. Adds a preferred_base field to the drmodtrack_info_t struct. There is no compatibility break as it has a struct_size field. Offline drmodtrack files do incur a version bump here, so an old reader will fail when reading a file with the new field. The field is set to a -1 sentinel to aid in determining whether a file has the field or not. This is also done here with the previously-added offset field. Adds some sanity checks to the corresponding tests. Fixes #4474
|
Windows failure looks like a pre-existing bug that happened to not fail the test: #4777 |
|
PR #4778 is fixing the Windows issue and will be merged into here afterward. |
abhinav92003
approved these changes
Mar 10, 2021
PR #2940 and #2973 added an offset field to drmodtrack for #2939, but they ifdef-ed the field in some places but not others, resulting in uninitialized output. Since it's already locked into the interface, we always set it to 0 here and include it in internal structures to fix the problem. Tested on drmodtrack-test where the fields were manually confirmed to no longer contain bogus values, and where the test doesn't fail when i#4474 adds a new field that shifts the test buffer to avoid the happens-to-match scenario that masked this bug in that test before. Issue: #2939, #4474, #4777 Fixes #4777
derekbruening
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a preferred_base field to the module_data_t struct. There is no
compatibility break as DR allocates all such structs.
Adds a preferred_base field to the drmodtrack_info_t struct. There is
no compatibility break as it has a struct_size field. Offline
drmodtrack files do incur a version bump here, so an old reader will
fail when reading a file with the new field. The field is set to a -1
sentinel to aid in determining whether a file has the field or not.
This is also done here with the previously-added offset field.
Adds some sanity checks to the corresponding tests.
Fixes #4774