Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i#2006 drcachesim: Support config files on other filesystems #4490

Merged
merged 1 commit into from
Oct 16, 2020

Conversation

derekbruening
Copy link
Contributor

Changes the drcachesim configuration file interface to use a
std::istream rather than a file path string, to support non-standard
filesystems.

Tested with a proprietary filesystem library.

Issue: #2006

Changes the drcachesim configuration file interface to use a
std::istream rather than a file path string, to support non-standard
filesystems.

Tested with a proprietary filesystem library.

Issue: #2006
@derekbruening derekbruening requested a review from xyzsam October 16, 2020 16:42
@derekbruening
Copy link
Contributor Author

The appveyor failure is a flaky test: it's client.winxfer, under #4058. I already tried to relax the output constraints in PR #4411 but apparently there is more nondeterminism in there. I put a comment in the issue for now.

@derekbruening derekbruening merged commit 9bedb9c into master Oct 16, 2020
@derekbruening derekbruening deleted the i2006-config-file-generalize branch October 16, 2020 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants