Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i#4318 xarch memtrace: Make alt lib dir take precedence #4360

Merged
merged 3 commits into from
Jul 7, 2020

Conversation

derekbruening
Copy link
Contributor

Moves the -alt_module_dir for finding binaries during trace
post-processing to take precedence over the recorded path, to allow
avoiding problems when an identical-seeming path exists on the
processing machine (e.g., system libraries) on UNIX where we have no
checksum or other library distinguisher.

Tested manually on a case where a system library in the same path as
on the recorded machine caused failure.

Issue: #4318

Moves the -alt_module_dir for finding binaries during trace
post-processing to take precedence over the recorded path, to allow
avoiding problems when an identical-seeming path exists on the
processing machine (e.g., system libraries) on UNIX where we have no
checksum or other library distinguisher.

Tested manually on a case where a system library in the same path as
on the recorded machine caused failure.

Issue: #4318
@derekbruening derekbruening requested a review from snehasish July 6, 2020 19:55
Copy link
Contributor

@snehasish snehasish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

read_and_map_modules is getting pretty complicated, it may be worth documenting the various strategies (and sub-strategies) as a function comment or refactoring them out as separate functions altogether.

@derekbruening
Copy link
Contributor Author

read_and_map_modules is getting pretty complicated, it may be worth documenting the various strategies (and sub-strategies) as a function comment or refactoring them out as separate functions altogether.

Added a function comment.

@derekbruening derekbruening merged commit 2d9004e into master Jul 7, 2020
@derekbruening derekbruening deleted the i4318-alt-dir-first branch July 7, 2020 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants