i#3320: Fix type_is_instr assert in drcachesim #3859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The type_is_instr() function deliberately excludes TRACE_TYPE_INSTR_NO_FETCH, yet we can have a bundle preceded by a no-fetch instruction. We relax the assert in the reader to reflect this. Fixes #3320
|
So the arm tests are running for devs but the "run arm tests" trigger is not working it seems. |
ofry
pushed a commit
to ofry/dynamorio
that referenced
this pull request
Sep 29, 2019
The type_is_instr() function deliberately excludes TRACE_TYPE_INSTR_NO_FETCH, yet we can have a bundle preceded by a no-fetch instruction. We relax the assert in the reader to reflect this. Fixes DynamoRIO#3320
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type_is_instr() function deliberately excludes
TRACE_TYPE_INSTR_NO_FETCH, yet we can have a bundle preceded by a
no-fetch instruction. We relax the assert in the reader to reflect
this.
Fixes #3320