Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i#3799: Fix leak and false trigger on DR reload #3800

Merged
merged 1 commit into from
Aug 22, 2019

Conversation

derekbruening
Copy link
Contributor

Adds ignoring of kernels labeling DR's .bss as "[heap]", to avoid
unnecessary reloading at startup.

Fixes failures to unmap the executable's headers on a reload.

Fixes #3799

Adds ignoring of kernels labeling DR's .bss as "[heap]", to avoid
unnecessary reloading at startup.

Fixes failures to unmap the executable's headers on a reload.

Fixes #3799
@hgreving2304
Copy link

The code_api|client.pcache-use test is quite flaky.

@derekbruening
Copy link
Contributor Author

pcache-use did fail but was auto-ignored since already on flaky list. The reason Appveyor is red is code_api|tool.drcachesim.missfile which is #3320.

@derekbruening derekbruening merged commit 80d2bc8 into master Aug 22, 2019
@derekbruening derekbruening deleted the i3799-dr-bss-heap branch August 22, 2019 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ASSERT os.c:9179 iter->vm_start == executable_start
2 participants